Do not fetch spans if not required.

This commit is contained in:
Camille GILLOT
2025-07-27 22:15:40 +00:00
parent c0fe285815
commit 1b01decc1c

View File

@@ -1423,8 +1423,6 @@ impl SearchInterfaceForPrivateItemsVisitor<'_> {
}; };
let vis = self.tcx.local_visibility(local_def_id); let vis = self.tcx.local_visibility(local_def_id);
let span = self.tcx.def_span(self.item_def_id.to_def_id());
let vis_span = self.tcx.def_span(def_id);
if self.in_assoc_ty && !vis.is_at_least(self.required_visibility, self.tcx) { if self.in_assoc_ty && !vis.is_at_least(self.required_visibility, self.tcx) {
let vis_descr = match vis { let vis_descr = match vis {
ty::Visibility::Public => "public", ty::Visibility::Public => "public",
@@ -1441,6 +1439,8 @@ impl SearchInterfaceForPrivateItemsVisitor<'_> {
} }
}; };
let span = self.tcx.def_span(self.item_def_id.to_def_id());
let vis_span = self.tcx.def_span(def_id);
self.tcx.dcx().emit_err(InPublicInterface { self.tcx.dcx().emit_err(InPublicInterface {
span, span,
vis_descr, vis_descr,
@@ -1463,6 +1463,8 @@ impl SearchInterfaceForPrivateItemsVisitor<'_> {
} else { } else {
lint::builtin::PRIVATE_BOUNDS lint::builtin::PRIVATE_BOUNDS
}; };
let span = self.tcx.def_span(self.item_def_id.to_def_id());
let vis_span = self.tcx.def_span(def_id);
self.tcx.emit_node_span_lint( self.tcx.emit_node_span_lint(
lint, lint,
self.tcx.local_def_id_to_hir_id(self.item_def_id), self.tcx.local_def_id_to_hir_id(self.item_def_id),