rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Explain side-effects from simplify_operand.

Browse Source
This commit is contained in:
Camille GILLOT
2024-01-08 22:44:38 +00:00
parent 22ed51e136
commit 166fe54eba
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
compiler/rustc_mir_transform/src/gvn.rs
View File

@@ -794,6 +794,8 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {
let ty = lhs.ty(self.local_decls, self.tcx); let ty = lhs.ty(self.local_decls, self.tcx);
let lhs = self.simplify_operand(lhs, location); let lhs = self.simplify_operand(lhs, location);
let rhs = self.simplify_operand(rhs, location); let rhs = self.simplify_operand(rhs, location);
// Only short-circuit options after we called `simplify_operand`
// on both operands for side effect.
let lhs = lhs?; let lhs = lhs?;
let rhs = rhs?; let rhs = rhs?;
if let Some(value) = self.simplify_binary(op, false, ty, lhs, rhs) { if let Some(value) = self.simplify_binary(op, false, ty, lhs, rhs) {
@@ -805,6 +807,8 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {
let ty = lhs.ty(self.local_decls, self.tcx); let ty = lhs.ty(self.local_decls, self.tcx);
let lhs = self.simplify_operand(lhs, location); let lhs = self.simplify_operand(lhs, location);
let rhs = self.simplify_operand(rhs, location); let rhs = self.simplify_operand(rhs, location);
// Only short-circuit options after we called `simplify_operand`
// on both operands for side effect.
let lhs = lhs?; let lhs = lhs?;
let rhs = rhs?; let rhs = rhs?;
if let Some(value) = self.simplify_binary(op, true, ty, lhs, rhs) { if let Some(value) = self.simplify_binary(op, true, ty, lhs, rhs) {