rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

chore(moduel_name_repeat): Rename stutter lint to module_name_repeat to avoid ableist language

Browse Source
This commit is contained in:
Klaus Purer
2018-12-16 14:10:53 +01:00
parent a416c5e0f7
commit 15b9e9f23a
4 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
clippy_lints/src/enum_variants.rs
View File

@@ -75,7 +75,7 @@ declare_clippy_lint! {
/// } /// }
/// ``` /// ```
declare_clippy_lint! { declare_clippy_lint! {
pub STUTTER, pub MODULE_NAME_REPEAT,
pedantic, pedantic,
"type names prefixed/postfixed with their containing module's name" "type names prefixed/postfixed with their containing module's name"
} }
@@ -126,7 +126,7 @@ impl EnumVariantNames {
impl LintPass for EnumVariantNames { impl LintPass for EnumVariantNames {
fn get_lints(&self) -> LintArray { fn get_lints(&self) -> LintArray {
lint_array!(ENUM_VARIANT_NAMES, PUB_ENUM_VARIANT_NAMES, STUTTER, MODULE_INCEPTION) lint_array!(ENUM_VARIANT_NAMES, PUB_ENUM_VARIANT_NAMES, MODULE_NAME_REPEAT, MODULE_INCEPTION)
} }
} }
@@ -277,7 +277,7 @@ impl EarlyLintPass for EnumVariantNames {
match item_camel.chars().nth(nchars) { match item_camel.chars().nth(nchars) {
Some(c) if is_word_beginning(c) => span_lint( Some(c) if is_word_beginning(c) => span_lint(
cx, cx,
STUTTER, MODULE_NAME_REPEAT,
item.span, item.span,
"item name starts with its containing module's name", "item name starts with its containing module's name",
), ),
@@ -287,7 +287,7 @@ impl EarlyLintPass for EnumVariantNames {
if rmatching == nchars { if rmatching == nchars {
span_lint( span_lint(
cx, cx,
STUTTER, MODULE_NAME_REPEAT,
item.span, item.span,
"item name ends with its containing module's name", "item name ends with its containing module's name",
); );

2
clippy_lints/src/lib.rs
View File

@@ -518,7 +518,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) {
empty_enum::EMPTY_ENUM, empty_enum::EMPTY_ENUM,
enum_glob_use::ENUM_GLOB_USE, enum_glob_use::ENUM_GLOB_USE,
enum_variants::PUB_ENUM_VARIANT_NAMES, enum_variants::PUB_ENUM_VARIANT_NAMES,
enum_variants::STUTTER, enum_variants::MODULE_NAME_REPEAT,
if_not_else::IF_NOT_ELSE, if_not_else::IF_NOT_ELSE,
infinite_iter::MAYBE_INFINITE_ITER, infinite_iter::MAYBE_INFINITE_ITER,
items_after_statements::ITEMS_AFTER_STATEMENTS, items_after_statements::ITEMS_AFTER_STATEMENTS,

2
tests/ui/stutter.rs → tests/ui/module_name_repeat.rs
View File

@@ -7,7 +7,7 @@
// option. This file may not be copied, modified, or distributed // option. This file may not be copied, modified, or distributed
// except according to those terms. // except according to those terms.
#![warn(clippy::stutter)] #![warn(clippy::module_name_repeat)]
#![allow(dead_code)] #![allow(dead_code)]
mod foo { mod foo {

12
tests/ui/stutter.stderr → tests/ui/module_name_repeat.stderr
View File

@@ -1,31 +1,31 @@
error: item name starts with its containing module's name error: item name starts with its containing module's name
--> $DIR/stutter.rs:15:5 --> $DIR/module_name_repeat.rs:15:5
| |
15 | pub fn foo_bar() {} 15 | pub fn foo_bar() {}
| ^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^
| |
= note: `-D clippy::stutter` implied by `-D warnings` = note: `-D clippy::module-name-repeat` implied by `-D warnings`
error: item name ends with its containing module's name error: item name ends with its containing module's name
--> $DIR/stutter.rs:16:5 --> $DIR/module_name_repeat.rs:16:5
| |
16 | pub fn bar_foo() {} 16 | pub fn bar_foo() {}
| ^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^
error: item name starts with its containing module's name error: item name starts with its containing module's name
--> $DIR/stutter.rs:17:5 --> $DIR/module_name_repeat.rs:17:5
| |
17 | pub struct FooCake {} 17 | pub struct FooCake {}
| ^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^
error: item name ends with its containing module's name error: item name ends with its containing module's name
--> $DIR/stutter.rs:18:5 --> $DIR/module_name_repeat.rs:18:5
| |
18 | pub enum CakeFoo {} 18 | pub enum CakeFoo {}
| ^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^
error: item name starts with its containing module's name error: item name starts with its containing module's name
--> $DIR/stutter.rs:19:5 --> $DIR/module_name_repeat.rs:19:5
| |
19 | pub struct Foo7Bar; 19 | pub struct Foo7Bar;
| ^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^