Deduplicate getting the path of a lib candidate

2024-03-23 14:59:31 +00:00
parent d6120810e5
commit 121dac5cbb
1 changed files with 4 additions and 6 deletions
--- a/compiler/rustc_metadata/src/locator.rs
+++ b/compiler/rustc_metadata/src/locator.rs
@@ -495,13 +495,11 @@ impl<'a> CrateLocator<'a> {
            0 => Ok(None),
            1 => Ok(Some(libraries.into_iter().next().unwrap().1)),
            _ => {
-                let mut libraries: Vec<_> = libraries.into_values().collect();
-
-                libraries.sort_by_cached_key(|lib| lib.source.paths().next().unwrap().clone());
-                let candidates = libraries
-                    .iter()
+                let mut candidates: Vec<PathBuf> = libraries
+                    .into_values()
                    .map(|lib| lib.source.paths().next().unwrap().clone())
-                    .collect::<Vec<_>>();
+                    .collect();
+                candidates.sort();

                Err(CrateError::MultipleCandidates(
                    self.crate_name,