rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixes missing overflow lint for i64 #14269

Browse Source 
The `type_overflow` lint, doesn't catch the overflow for `i64` because
the overflow happens earlier in the parse phase when the `u64` as biggest
possible int gets casted to `i64` , without checking the for overflows.
We can't lint in the parse phase, so a refactoring of the `LitInt` type
was necessary.

The types `LitInt`, `LitUint` and `LitIntUnsuffixed` where merged to one
type `LitInt` which stores it's value as `u64`. An additional parameter was
added which indicate the signedness of the type and the sign of the value.
This commit is contained in:
Falco Hirschenberger
2014-08-05 09:59:03 +02:00
parent 795f6ae829
commit 0dc215741b
18 changed files with 142 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/libsyntax/print/pprust.rs
View File

@@ -2415,15 +2415,25 @@ impl<'a> State<'a> {
word(&mut self.s, res.as_slice())
}
ast::LitInt(i, t) => {
word(&mut self.s,
ast_util::int_ty_to_string(t, Some(i)).as_slice())
}
ast::LitUint(u, t) => {
word(&mut self.s,
ast_util::uint_ty_to_string(t, Some(u)).as_slice())
}
ast::LitIntUnsuffixed(i) => {
word(&mut self.s, format!("{}", i).as_slice())
match t {
ast::SignedIntLit(st, ast::Plus) => {
word(&mut self.s,
ast_util::int_ty_to_string(st, Some(i as i64)).as_slice())
}
ast::SignedIntLit(st, ast::Minus) => {
word(&mut self.s,
ast_util::int_ty_to_string(st, Some(-(i as i64))).as_slice())
}
ast::UnsignedIntLit(ut) => {
word(&mut self.s, ast_util::uint_ty_to_string(ut, Some(i)).as_slice())
}
ast::UnsuffixedIntLit(ast::Plus) => {
word(&mut self.s, format!("{}", i).as_slice())
}
ast::UnsuffixedIntLit(ast::Minus) => {
word(&mut self.s, format!("-{}", i).as_slice())
}
}
}
ast::LitFloat(ref f, t) => {
word(&mut self.s,