misapplied optimize attribute throws a compilation error (#128488)

2024-10-20 08:34:15 -06:00
parent 798fb83f7d
commit 080103f1ed
8 changed files with 117 additions and 71 deletions
--- a/compiler/rustc_passes/src/errors.rs
+++ b/compiler/rustc_passes/src/errors.rs
@@ -76,9 +76,15 @@ pub(crate) struct CoverageNotFnOrClosure {
    pub defn_span: Span,
 }

-#[derive(LintDiagnostic)]
-#[diag(passes_optimize_not_fn_or_closure)]
-pub(crate) struct OptimizeNotFnOrClosure;
+#[derive(Diagnostic)]
+#[diag(passes_optimize_invalid_target)]
+pub(crate) struct OptimizeInvalidTarget {
+    #[primary_span]
+    pub attr_span: Span,
+    #[label]
+    pub defn_span: Span,
+    pub on_crate: bool,
+}

 #[derive(Diagnostic)]
 #[diag(passes_should_be_applied_to_fn)]