rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #1307 from Kha/partialeq_ne

Browse Source 
Implement 'Re-implementing `PartialEq::ne`' lint
This commit is contained in:
Oliver Schneider
2016-10-31 09:06:14 -04:00
committed by GitHub
parent 8b2e80b47b 9314965af0
commit 053896b678
9 changed files with 93 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
clippy_lints/src/utils/inspector.rs
View File

@@ -4,7 +4,8 @@
use rustc::lint::*;
use rustc::hir;
use syntax::ast::{Attribute, MetaItemKind};
use syntax::ast::Attribute;
use syntax::attr;
/// **What it does:** Dumps every ast/hir node which has the `#[clippy_dump]` attribute
///
@@ -128,10 +129,7 @@ impl LateLintPass for Pass {
}
fn has_attr(attrs: &[Attribute]) -> bool {
attrs.iter().any(|attr| match attr.node.value.node {
MetaItemKind::Word(ref word) => word == "clippy_dump",
_ => false,
})
attr::contains_name(attrs, "clippy_dump")
}
fn print_decl(cx: &LateContext, decl: &hir::Decl) {
@@ -381,12 +379,12 @@ fn print_item(cx: &LateContext, item: &hir::Item) {
}
},
hir::ItemDefaultImpl(_, ref trait_ref) => {
let trait_did = cx.tcx.map.local_def_id(trait_ref.ref_id);
println!("default impl for `{:?}`", cx.tcx.item_path_str(trait_did));
let trait_did = cx.tcx.expect_def(trait_ref.ref_id).def_id();
println!("default impl for `{}`", cx.tcx.item_path_str(trait_did));
},
hir::ItemImpl(_, _, _, Some(ref trait_ref), _, _) => {
let trait_did = cx.tcx.map.local_def_id(trait_ref.ref_id);
println!("impl of trait `{:?}`", cx.tcx.item_path_str(trait_did));
let trait_did = cx.tcx.expect_def(trait_ref.ref_id).def_id();
println!("impl of trait `{}`", cx.tcx.item_path_str(trait_did));
},
hir::ItemImpl(_, _, _, None, _, _) => {
println!("impl");

6
clippy_lints/src/utils/mod.rs
View File

@@ -14,6 +14,7 @@ use std::env;
use std::mem;
use std::str::FromStr;
use syntax::ast::{self, LitKind};
use syntax::attr;
use syntax::codemap::{ExpnFormat, ExpnInfo, MultiSpan, Span, DUMMY_SP};
use syntax::errors::DiagnosticBuilder;
use syntax::ptr::P;
@@ -761,3 +762,8 @@ pub fn is_refutable(cx: &LateContext, pat: &Pat) -> bool {
}
}
}
/// Checks for the `#[automatically_derived]` attribute all `#[derive]`d implementations have.
pub fn is_automatically_derived(attrs: &[ast::Attribute]) -> bool {
attr::contains_name(attrs, "automatically_derived")
}