rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
bcfea1f8d253fd43eab36832fa601d192ac603d5
rust/tests/ui/stability-attribute/missing-const-stability.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

30 lines
804 B
Plaintext
Raw Normal View History

Require const stability on all stable const items This was supposed to be the case previously, but a missed method call meant that trait impls were not checked.
2021-11-17 21:06:17 -05:00
error: function has missing const stability attribute
Migrate tests to use `-Znext-solver`
2024-06-30 17:08:45 +00:00
--> $DIR/missing-const-stability.rs:7:1
Test for missing const-stability attributes
2020-09-25 13:51:52 -07:00
|
LL | pub const fn foo() {}
| ^^^^^^^^^^^^^^^^^^^^^
Proper const stability check, default to unstable Rather than deferring to const eval for checking if a trait is const, we now check up-front. This allows the error to be emitted earlier, notably at the same time as other stability checks. Also included in this commit is a change of the default const stability level to UNstable. Previously, an item that was `const` but did not explicitly state it was unstable was implicitly stable.
2022-02-13 05:54:00 -05:00
error: implementation has missing const stability attribute
Migrate tests to use `-Znext-solver`
2024-06-30 17:08:45 +00:00
--> $DIR/missing-const-stability.rs:29:1
Proper const stability check, default to unstable Rather than deferring to const eval for checking if a trait is const, we now check up-front. This allows the error to be emitted earlier, notably at the same time as other stability checks. Also included in this commit is a change of the default const stability level to UNstable. Previously, an item that was `const` but did not explicitly state it was unstable was implicitly stable.
2022-02-13 05:54:00 -05:00
|
LL | / impl const Bar for Foo {
LL | |
LL | | fn fun() {}
LL | | }
| |_^
Re-do recursive const stability checks Fundamentally, we have *three* disjoint categories of functions: 1. const-stable functions 2. private/unstable functions that are meant to be callable from const-stable functions 3. functions that can make use of unstable const features This PR implements the following system: - `#[rustc_const_stable]` puts functions in the first category. It may only be applied to `#[stable]` functions. - `#[rustc_const_unstable]` by default puts functions in the third category. The new attribute `#[rustc_const_stable_indirect]` can be added to such a function to move it into the second category. - `const fn` without a const stability marker are in the second category if they are still unstable. They automatically inherit the feature gate for regular calls, it can now also be used for const-calls. Also, several holes in recursive const stability checking are being closed. There's still one potential hole that is hard to avoid, which is when MIR building automatically inserts calls to a particular function in stable functions -- which happens in the panic machinery. Those need to *not* be `rustc_const_unstable` (or manually get a `rustc_const_stable_indirect`) to be sure they follow recursive const stability. But that's a fairly rare and special case so IMO it's fine. The net effect of this is that a `#[unstable]` or unmarked function can be constified simply by marking it as `const fn`, and it will then be const-callable from stable `const fn` and subject to recursive const stability requirements. If it is publicly reachable (which implies it cannot be unmarked), it will be const-unstable under the same feature gate. Only if the function ever becomes `#[stable]` does it need a `#[rustc_const_unstable]` or `#[rustc_const_stable]` marker to decide if this should also imply const-stability. Adding `#[rustc_const_unstable]` is only needed for (a) functions that need to use unstable const lang features (including intrinsics), or (b) `#[stable]` functions that are not yet intended to be const-stable. Adding `#[rustc_const_stable]` is only needed for functions that are actually meant to be directly callable from stable const code. `#[rustc_const_stable_indirect]` is used to mark intrinsics as const-callable and for `#[rustc_const_unstable]` functions that are actually called from other, exposed-on-stable `const fn`. No other attributes are required.
2024-10-06 19:59:19 +02:00
error: function has missing const stability attribute
--> $DIR/missing-const-stability.rs:36:1
|
LL | pub const unsafe fn size_of_val<T>(x: *const T) -> usize { 42 }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Reword comments and rename HIR visiting methods.
2022-07-03 15:28:57 +02:00
error: associated function has missing const stability attribute
Migrate tests to use `-Znext-solver`
2024-06-30 17:08:45 +00:00
--> $DIR/missing-const-stability.rs:16:5
Reword comments and rename HIR visiting methods.
2022-07-03 15:28:57 +02:00
|
LL | pub const fn foo() {}
| ^^^^^^^^^^^^^^^^^^^^^
Yeet effects feature
2024-10-30 18:03:44 +00:00
error: aborting due to 4 previous errors
Test for missing const-stability attributes
2020-09-25 13:51:52 -07:00
Reference in New Issue Copy Permalink