Files
rust/crates/ra_ide/src/diagnostics/diagnostics_with_fix.rs

172 lines
6.3 KiB
Rust
Raw Normal View History

2020-08-11 15:08:55 +03:00
//! Provides a way to derive fixes based on the diagnostic data.
2020-08-11 00:55:57 +03:00
use crate::Fix;
use ast::{edit::IndentLevel, make};
use hir::{
db::AstDatabase,
diagnostics::{MissingFields, MissingOkInTailExpr, NoSuchField, UnresolvedModule},
2020-08-11 00:55:57 +03:00
HasSource, HirDisplay, Semantics, VariantDef,
};
2020-08-11 00:55:57 +03:00
use ra_db::FileId;
use ra_ide_db::{
source_change::{FileSystemEdit, SourceFileEdit},
RootDatabase,
};
use ra_syntax::{algo, ast, AstNode, TextRange};
use ra_text_edit::{TextEdit, TextEditBuilder};
2020-08-11 15:08:55 +03:00
/// A trait to implement fot the Diagnostic that has a fix available.
pub trait DiagnosticWithFix {
2020-08-11 15:08:55 +03:00
/// Provides a fix with the fix range, if applicable in the current semantics.
2020-08-11 00:55:57 +03:00
fn fix(&self, sema: &Semantics<RootDatabase>) -> Option<(Fix, TextRange)>;
}
impl DiagnosticWithFix for UnresolvedModule {
2020-08-11 00:55:57 +03:00
fn fix(&self, sema: &Semantics<RootDatabase>) -> Option<(Fix, TextRange)> {
let fix = Fix::new(
"Create module",
FileSystemEdit::CreateFile {
anchor: self.file.original_file(sema.db),
dst: self.candidate.clone(),
}
.into(),
);
let root = sema.db.parse_or_expand(self.file)?;
let unresolved_module = self.decl.to_node(&root);
Some((fix, unresolved_module.syntax().text_range()))
}
}
impl DiagnosticWithFix for NoSuchField {
2020-08-11 00:55:57 +03:00
fn fix(&self, sema: &Semantics<RootDatabase>) -> Option<(Fix, TextRange)> {
let root = sema.db.parse_or_expand(self.file)?;
let record_expr_field = self.field.to_node(&root);
let fix =
missing_struct_field_fix(&sema, self.file.original_file(sema.db), &record_expr_field)?;
Some((fix, record_expr_field.syntax().text_range()))
}
}
impl DiagnosticWithFix for MissingFields {
2020-08-11 00:55:57 +03:00
fn fix(&self, sema: &Semantics<RootDatabase>) -> Option<(Fix, TextRange)> {
// Note that although we could add a diagnostics to
// fill the missing tuple field, e.g :
// `struct A(usize);`
// `let a = A { 0: () }`
// but it is uncommon usage and it should not be encouraged.
if self.missed_fields.iter().any(|it| it.as_tuple_index().is_some()) {
None
} else {
let root = sema.db.parse_or_expand(self.file)?;
let old_field_list = self.field_list_parent.to_node(&root).record_expr_field_list()?;
let mut new_field_list = old_field_list.clone();
for f in self.missed_fields.iter() {
let field = make::record_expr_field(
make::name_ref(&f.to_string()),
Some(make::expr_unit()),
);
new_field_list = new_field_list.append_field(&field);
}
2020-08-11 00:55:57 +03:00
let edit = {
let mut builder = TextEditBuilder::default();
algo::diff(&old_field_list.syntax(), &new_field_list.syntax())
.into_text_edit(&mut builder);
builder.finish()
};
Some((
Fix::new(
"Fill struct fields",
SourceFileEdit { file_id: self.file.original_file(sema.db), edit }.into(),
),
sema.original_range(&old_field_list.syntax()).range,
// old_field_list.syntax().text_range(),
))
}
}
}
impl DiagnosticWithFix for MissingOkInTailExpr {
2020-08-11 00:55:57 +03:00
fn fix(&self, sema: &Semantics<RootDatabase>) -> Option<(Fix, TextRange)> {
let root = sema.db.parse_or_expand(self.file)?;
let tail_expr = self.expr.to_node(&root);
let tail_expr_range = tail_expr.syntax().text_range();
let edit = TextEdit::replace(tail_expr_range, format!("Ok({})", tail_expr.syntax()));
let source_change =
SourceFileEdit { file_id: self.file.original_file(sema.db), edit }.into();
Some((Fix::new("Wrap with ok", source_change), tail_expr_range))
}
}
fn missing_struct_field_fix(
sema: &Semantics<RootDatabase>,
usage_file_id: FileId,
record_expr_field: &ast::RecordExprField,
) -> Option<Fix> {
let record_lit = ast::RecordExpr::cast(record_expr_field.syntax().parent()?.parent()?)?;
let def_id = sema.resolve_variant(record_lit)?;
let module;
let def_file_id;
let record_fields = match VariantDef::from(def_id) {
VariantDef::Struct(s) => {
module = s.module(sema.db);
let source = s.source(sema.db);
def_file_id = source.file_id;
let fields = source.value.field_list()?;
record_field_list(fields)?
}
VariantDef::Union(u) => {
module = u.module(sema.db);
let source = u.source(sema.db);
def_file_id = source.file_id;
source.value.record_field_list()?
}
VariantDef::EnumVariant(e) => {
module = e.module(sema.db);
let source = e.source(sema.db);
def_file_id = source.file_id;
let fields = source.value.field_list()?;
record_field_list(fields)?
}
};
let def_file_id = def_file_id.original_file(sema.db);
let new_field_type = sema.type_of_expr(&record_expr_field.expr()?)?;
if new_field_type.is_unknown() {
return None;
}
let new_field = make::record_field(
record_expr_field.field_name()?,
make::ty(&new_field_type.display_source_code(sema.db, module.into()).ok()?),
);
let last_field = record_fields.fields().last()?;
let last_field_syntax = last_field.syntax();
let indent = IndentLevel::from_node(last_field_syntax);
let mut new_field = new_field.to_string();
if usage_file_id != def_file_id {
new_field = format!("pub(crate) {}", new_field);
}
new_field = format!("\n{}{}", indent, new_field);
let needs_comma = !last_field_syntax.to_string().ends_with(',');
if needs_comma {
new_field = format!(",{}", new_field);
}
let source_change = SourceFileEdit {
file_id: def_file_id,
edit: TextEdit::insert(last_field_syntax.text_range().end(), new_field),
};
let fix = Fix::new("Create field", source_change.into());
return Some(fix);
2020-08-11 00:55:57 +03:00
fn record_field_list(field_def_list: ast::FieldList) -> Option<ast::RecordFieldList> {
match field_def_list {
ast::FieldList::RecordFieldList(it) => Some(it),
ast::FieldList::TupleFieldList(_) => None,
}
}
}