rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
359bfa901b9d8eddbed7b88b6716dbb77b7bfb95
rust/tests/ui/traits/dispatch-from-dyn-invalid-impls.stderr

61 lines
2.3 KiB
Plaintext
Raw Normal View History

Don't allow transmuting ZSTs in dispatch_from_dyn impl
2025-01-08 00:28:47 +00:00
error[E0378]: the trait `DispatchFromDyn` may only be implemented for structs containing the field being coerced, ZST fields with 1 byte alignment that don't mention type/const generics, and nothing else
cleaned up some tests
2025-06-12 20:49:48 +05:00
--> $DIR/dispatch-from-dyn-invalid-impls.rs:19:1
Replace CoerceSized trait with DispatchFromDyn Rename `CoerceSized` to `DispatchFromDyn`, and reverse the direction so that, for example, you write ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const U> for *const T {} ``` instead of ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const T> for *const U {} ``` this way the trait is really just a subset of `CoerceUnsized`. The checks in object_safety.rs are updated for the new trait, and some documentation and method names in there are updated for the new trait name — e.g. `receiver_is_coercible` is now called `receiver_is_dispatchable`. Since the trait now works in the opposite direction, some code had to updated here for that too. I did not update the error messages for invalid `CoerceSized` (now `DispatchFromDyn`) implementations, except to find/replace `CoerceSized` with `DispatchFromDyn`. Will ask for suggestions in the PR thread.
2018-10-03 23:40:21 -04:00
|
Extend impl's def_span to include where clauses
2023-10-06 20:35:52 +00:00
LL | / impl<T, U> DispatchFromDyn<WrapperWithExtraField<U>> for WrapperWithExtraField<T>
Consolidate and rework CoercePointee and DispatchFromDyn errors
2025-02-19 19:10:01 +00:00
LL | |
Extend impl's def_span to include where clauses
2023-10-06 20:35:52 +00:00
LL | | where
cleaned up some tests
2025-06-12 20:49:48 +05:00
LL | | T: DispatchFromDyn<U>
| |_________________________^
Replace CoerceSized trait with DispatchFromDyn Rename `CoerceSized` to `DispatchFromDyn`, and reverse the direction so that, for example, you write ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const U> for *const T {} ``` instead of ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const T> for *const U {} ``` this way the trait is really just a subset of `CoerceUnsized`. The checks in object_safety.rs are updated for the new trait, and some documentation and method names in there are updated for the new trait name — e.g. `receiver_is_coercible` is now called `receiver_is_dispatchable`. Since the trait now works in the opposite direction, some code had to updated here for that too. I did not update the error messages for invalid `CoerceSized` (now `DispatchFromDyn`) implementations, except to find/replace `CoerceSized` with `DispatchFromDyn`. Will ask for suggestions in the PR thread.
2018-10-03 23:40:21 -04:00
|
= note: extra field `1` of type `i32` is not allowed
Consolidate and rework CoercePointee and DispatchFromDyn errors
2025-02-19 19:10:01 +00:00
error[E0375]: implementing `DispatchFromDyn` does not allow multiple fields to be coerced
cleaned up some tests
2025-06-12 20:49:48 +05:00
--> $DIR/dispatch-from-dyn-invalid-impls.rs:32:1
Replace CoerceSized trait with DispatchFromDyn Rename `CoerceSized` to `DispatchFromDyn`, and reverse the direction so that, for example, you write ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const U> for *const T {} ``` instead of ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const T> for *const U {} ``` this way the trait is really just a subset of `CoerceUnsized`. The checks in object_safety.rs are updated for the new trait, and some documentation and method names in there are updated for the new trait name — e.g. `receiver_is_coercible` is now called `receiver_is_dispatchable`. Since the trait now works in the opposite direction, some code had to updated here for that too. I did not update the error messages for invalid `CoerceSized` (now `DispatchFromDyn`) implementations, except to find/replace `CoerceSized` with `DispatchFromDyn`. Will ask for suggestions in the PR thread.
2018-10-03 23:40:21 -04:00
|
Extend impl's def_span to include where clauses
2023-10-06 20:35:52 +00:00
LL | / impl<T: ?Sized, U: ?Sized> DispatchFromDyn<MultiplePointers<U>> for MultiplePointers<T>
Consolidate and rework CoercePointee and DispatchFromDyn errors
2025-02-19 19:10:01 +00:00
LL | |
Extend impl's def_span to include where clauses
2023-10-06 20:35:52 +00:00
LL | | where
cleaned up some tests
2025-06-12 20:49:48 +05:00
LL | | T: Unsize<U>
| |________________^
Replace CoerceSized trait with DispatchFromDyn Rename `CoerceSized` to `DispatchFromDyn`, and reverse the direction so that, for example, you write ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const U> for *const T {} ``` instead of ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const T> for *const U {} ``` this way the trait is really just a subset of `CoerceUnsized`. The checks in object_safety.rs are updated for the new trait, and some documentation and method names in there are updated for the new trait name — e.g. `receiver_is_coercible` is now called `receiver_is_dispatchable`. Since the trait now works in the opposite direction, some code had to updated here for that too. I did not update the error messages for invalid `CoerceSized` (now `DispatchFromDyn`) implementations, except to find/replace `CoerceSized` with `DispatchFromDyn`. Will ask for suggestions in the PR thread.
2018-10-03 23:40:21 -04:00
|
Consolidate and rework CoercePointee and DispatchFromDyn errors
2025-02-19 19:10:01 +00:00
note: the trait `DispatchFromDyn` may only be implemented when a single field is being coerced
cleaned up some tests
2025-06-12 20:49:48 +05:00
--> $DIR/dispatch-from-dyn-invalid-impls.rs:28:5
Consolidate and rework CoercePointee and DispatchFromDyn errors
2025-02-19 19:10:01 +00:00
|
LL | ptr1: *const T,
| ^^^^^^^^^^^^^^
LL | ptr2: *const T,
| ^^^^^^^^^^^^^^
Replace CoerceSized trait with DispatchFromDyn Rename `CoerceSized` to `DispatchFromDyn`, and reverse the direction so that, for example, you write ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const U> for *const T {} ``` instead of ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const T> for *const U {} ``` this way the trait is really just a subset of `CoerceUnsized`. The checks in object_safety.rs are updated for the new trait, and some documentation and method names in there are updated for the new trait name — e.g. `receiver_is_coercible` is now called `receiver_is_dispatchable`. Since the trait now works in the opposite direction, some code had to updated here for that too. I did not update the error messages for invalid `CoerceSized` (now `DispatchFromDyn`) implementations, except to find/replace `CoerceSized` with `DispatchFromDyn`. Will ask for suggestions in the PR thread.
2018-10-03 23:40:21 -04:00
Consolidate and rework CoercePointee and DispatchFromDyn errors
2025-02-19 19:10:01 +00:00
error[E0374]: implementing `DispatchFromDyn` requires a field to be coerced
cleaned up some tests
2025-06-12 20:49:48 +05:00
--> $DIR/dispatch-from-dyn-invalid-impls.rs:44:1
Replace CoerceSized trait with DispatchFromDyn Rename `CoerceSized` to `DispatchFromDyn`, and reverse the direction so that, for example, you write ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const U> for *const T {} ``` instead of ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const T> for *const U {} ``` this way the trait is really just a subset of `CoerceUnsized`. The checks in object_safety.rs are updated for the new trait, and some documentation and method names in there are updated for the new trait name — e.g. `receiver_is_coercible` is now called `receiver_is_dispatchable`. Since the trait now works in the opposite direction, some code had to updated here for that too. I did not update the error messages for invalid `CoerceSized` (now `DispatchFromDyn`) implementations, except to find/replace `CoerceSized` with `DispatchFromDyn`. Will ask for suggestions in the PR thread.
2018-10-03 23:40:21 -04:00
|
LL | impl<T: ?Sized, U: ?Sized> DispatchFromDyn<NothingToCoerce<T>> for NothingToCoerce<U> {}
Shorten def_span for more items.
2022-02-13 16:27:59 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Migrate `rustc_hir_analysis` to session diagnostic Part 5: Finishing `coherence/builtin.rs` file
2023-09-13 20:42:56 +03:00
|
= note: expected a single field to be coerced, none found
Replace CoerceSized trait with DispatchFromDyn Rename `CoerceSized` to `DispatchFromDyn`, and reverse the direction so that, for example, you write ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const U> for *const T {} ``` instead of ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const T> for *const U {} ``` this way the trait is really just a subset of `CoerceUnsized`. The checks in object_safety.rs are updated for the new trait, and some documentation and method names in there are updated for the new trait name — e.g. `receiver_is_coercible` is now called `receiver_is_dispatchable`. Since the trait now works in the opposite direction, some code had to updated here for that too. I did not update the error messages for invalid `CoerceSized` (now `DispatchFromDyn`) implementations, except to find/replace `CoerceSized` with `DispatchFromDyn`. Will ask for suggestions in the PR thread.
2018-10-03 23:40:21 -04:00
Add a check for reprs that could change the ABI disallow `#[repr(C)] and `#[repr(packed)]` on structs implementing DispatchFromDyn because they will change the ABI from Scalar/ScalarPair to Aggregrate, resulting in an ICE during object-safety checks or codegen
2018-10-26 01:09:33 -04:00
error[E0378]: structs implementing `DispatchFromDyn` may not have `#[repr(packed)]` or `#[repr(C)]`
cleaned up some tests
2025-06-12 20:49:48 +05:00
--> $DIR/dispatch-from-dyn-invalid-impls.rs:51:1
Add a check for reprs that could change the ABI disallow `#[repr(C)] and `#[repr(packed)]` on structs implementing DispatchFromDyn because they will change the ABI from Scalar/ScalarPair to Aggregrate, resulting in an ICE during object-safety checks or codegen
2018-10-26 01:09:33 -04:00
|
Extend impl's def_span to include where clauses
2023-10-06 20:35:52 +00:00
LL | / impl<T: ?Sized, U: ?Sized> DispatchFromDyn<HasReprC<U>> for HasReprC<T>
Consolidate and rework CoercePointee and DispatchFromDyn errors
2025-02-19 19:10:01 +00:00
LL | |
Extend impl's def_span to include where clauses
2023-10-06 20:35:52 +00:00
LL | | where
cleaned up some tests
2025-06-12 20:49:48 +05:00
LL | | T: Unsize<U>
| |________________^
Add a check for reprs that could change the ABI disallow `#[repr(C)] and `#[repr(packed)]` on structs implementing DispatchFromDyn because they will change the ABI from Scalar/ScalarPair to Aggregrate, resulting in an ICE during object-safety checks or codegen
2018-10-26 01:09:33 -04:00
Don't allow transmuting ZSTs in dispatch_from_dyn impl
2025-01-08 00:28:47 +00:00
error[E0378]: the trait `DispatchFromDyn` may only be implemented for structs containing the field being coerced, ZST fields with 1 byte alignment that don't mention type/const generics, and nothing else
cleaned up some tests
2025-06-12 20:49:48 +05:00
--> $DIR/dispatch-from-dyn-invalid-impls.rs:64:1
Only allow ZSTs with 1 byte alignment
2019-04-30 14:38:17 +02:00
|
Extend impl's def_span to include where clauses
2023-10-06 20:35:52 +00:00
LL | / impl<T: ?Sized, U: ?Sized> DispatchFromDyn<OverAligned<U>> for OverAligned<T>
Consolidate and rework CoercePointee and DispatchFromDyn errors
2025-02-19 19:10:01 +00:00
LL | |
cleaned up some tests
2025-06-12 20:49:48 +05:00
LL | | where
LL | | T: Unsize<U>
| |________________^
Only allow ZSTs with 1 byte alignment
2019-04-30 14:38:17 +02:00
|
= note: extra field `1` of type `OverAlignedZst` is not allowed
error: aborting due to 5 previous errors
Replace CoerceSized trait with DispatchFromDyn Rename `CoerceSized` to `DispatchFromDyn`, and reverse the direction so that, for example, you write ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const U> for *const T {} ``` instead of ``` impl<T: Unsize<U>, U> DispatchFromDyn<*const T> for *const U {} ``` this way the trait is really just a subset of `CoerceUnsized`. The checks in object_safety.rs are updated for the new trait, and some documentation and method names in there are updated for the new trait name — e.g. `receiver_is_coercible` is now called `receiver_is_dispatchable`. Since the trait now works in the opposite direction, some code had to updated here for that too. I did not update the error messages for invalid `CoerceSized` (now `DispatchFromDyn`) implementations, except to find/replace `CoerceSized` with `DispatchFromDyn`. Will ask for suggestions in the PR thread.
2018-10-03 23:40:21 -04:00
Consolidate and rework CoercePointee and DispatchFromDyn errors
2025-02-19 19:10:01 +00:00
Some errors have detailed explanations: E0374, E0375, E0378.
For more information about an error, try `rustc --explain E0374`.
Reference in New Issue Copy Permalink