rust/tests/ui/borrowck/issue-93093.rs

//@ edition:2018
struct S {
    foo: usize,
}
impl S {
    async fn bar(&self) { //~ HELP consider changing this to be a mutable reference
        //~| SUGGESTION mut
        self.foo += 1; //~ ERROR cannot assign to `self.foo`, which is behind a `&` reference [E0594]
    }
}

fn main() {
    S { foo: 1 }.bar();
}
[AUTO-GENERATED] Migrate ui tests from `//` to `//@` directives 2024-02-16 20:02:50 +00:00			`//@ edition:2018`
[borrowck] Fix help on mutating &self in async fns Previously, when rustc was provided an async function that tried to mutate through a shared reference to an implicit self (as shown in the ui test), rustc would suggest modifying the parameter signature to `&mut` + the fully qualified name of the ty (in the case of the repro `S`). If a user modified their code to match the suggestion, the compiler would not accept it. This commit modifies the suggestion so that when rustc is provided the ui test that is also attached in this commit, it suggests (correctly) `&mut self`. We try to be careful about distinguishing between implicit and explicit self annotations, since the latter seem to be handled correctly already. Fixes rust-lang/rust#93093 2022-01-22 15:35:09 -08:00			`struct S {`
			`foo: usize,`
			`}`
			`impl S {`
			`async fn bar(&self) { //~ HELP consider changing this to be a mutable reference`
Tweak `&mut self` suggestion span ``` error[E0596]: cannot borrow `*self.s` as mutable, as it is behind a `&` reference --> $DIR/issue-38147-1.rs:17:9 \| LL \| self.s.push('x'); \| ^^^^^^ `self` is a `&` reference, so the data it refers to cannot be borrowed as mutable \| help: consider changing this to be a mutable reference \| LL \| fn f(&mut self) { \| +++ ``` Note the suggestion to add `mut` instead of replacing the entire `&self` with `&mut self`. 2025-01-28 19:35:31 +00:00			`//~\| SUGGESTION mut`
[borrowck] Fix help on mutating &self in async fns Previously, when rustc was provided an async function that tried to mutate through a shared reference to an implicit self (as shown in the ui test), rustc would suggest modifying the parameter signature to `&mut` + the fully qualified name of the ty (in the case of the repro `S`). If a user modified their code to match the suggestion, the compiler would not accept it. This commit modifies the suggestion so that when rustc is provided the ui test that is also attached in this commit, it suggests (correctly) `&mut self`. We try to be careful about distinguishing between implicit and explicit self annotations, since the latter seem to be handled correctly already. Fixes rust-lang/rust#93093 2022-01-22 15:35:09 -08:00			self.foo += 1; //~ ERROR cannot assign to `self.foo`, which is behind a `&` reference [E0594]
			`}`
			`}`

			`fn main() {`
			`S { foo: 1 }.bar();`
			`}`