leizongmin/js-xss
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: problem with not closed tag (#262)

Browse Source
This commit is contained in:
Sviataslau Shchaurouski
2022-08-16 15:50:26 +02:00
committed by GitHub
parent c2419c4d14
commit 72844ddc6f
4 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dist/xss.js vendored
View File

@@ -586,7 +586,7 @@ function parseTag(html, onTag, escapeHtml) {
lastPos = currentPos; lastPos = currentPos;
continue; continue;
} }
if (c === ">") { if (c === ">" || currentPos === len - 1) {
rethtml += escapeHtml(html.slice(lastPos, tagStart)); rethtml += escapeHtml(html.slice(lastPos, tagStart));
currentHtml = html.slice(tagStart, currentPos + 1); currentHtml = html.slice(tagStart, currentPos + 1);
currentTagName = getTagName(currentHtml); currentTagName = getTagName(currentHtml);
@@ -621,7 +621,7 @@ function parseTag(html, onTag, escapeHtml) {
} }
} }
} }
if (lastPos < html.length) { if (lastPos < len) {
rethtml += escapeHtml(html.substr(lastPos)); rethtml += escapeHtml(html.substr(lastPos));
} }

2
dist/xss.min.js vendored
View File

File diff suppressed because one or more lines are too long

4
lib/parser.js
View File

@@ -71,7 +71,7 @@ function parseTag(html, onTag, escapeHtml) {
lastPos = currentPos; lastPos = currentPos;
continue; continue;
} }
if (c === ">") { if (c === ">" || currentPos === len - 1) {
rethtml += escapeHtml(html.slice(lastPos, tagStart)); rethtml += escapeHtml(html.slice(lastPos, tagStart));
currentHtml = html.slice(tagStart, currentPos + 1); currentHtml = html.slice(tagStart, currentPos + 1);
currentTagName = getTagName(currentHtml); currentTagName = getTagName(currentHtml);
@@ -106,7 +106,7 @@ function parseTag(html, onTag, escapeHtml) {
} }
} }
} }
if (lastPos < html.length) { if (lastPos < len) {
rethtml += escapeHtml(html.substr(lastPos)); rethtml += escapeHtml(html.substr(lastPos));
} }

1
test/test_xss.js
View File

@@ -88,6 +88,7 @@ describe("test XSS", function() {
assert.equal(xss("<img src//>"), "<img src />"); assert.equal(xss("<img src//>"), "<img src />");
assert.equal(xss("<br/>"), "<br />"); assert.equal(xss("<br/>"), "<br />");
assert.equal(xss("<br />"), "<br />"); assert.equal(xss("<br />"), "<br />");
assert.equal(xss("<img src=x onerror=alert('XSS')"), "<img src>");
// 畸形属性格式 // 畸形属性格式
assert.equal( assert.equal(