kubernetes-client/csharp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Exec hangs (#1267)

Browse Source 
* fix: exec hanging

* fix: exec hang

* chore: increase buffer

* chore: add StandardOutput timeout

* chore: switch to event based

* chore: simplify logic

* chore: fix logic

* fix: remove async

* chore: simplify logic

* fix: revert to non Event based logic

* fix: simplify logic

* fix: switch to GetAwaiter().GetResult()

* feat: externalize exec timeout

* feat: send errors to event

* chore: formatting

* fix: add null check for event handler

* feat: switch to TimeSpan
This commit is contained in:
Ivan Josipovic
2023-04-30 22:28:17 -07:00
committed by GitHub
parent 2a37ba86ad
commit 7508ffeec1
1 changed files with 21 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/KubernetesClient/KubernetesClientConfiguration.ConfigFile.cs
View File

@@ -28,6 +28,16 @@ namespace k8s
// For testing
internal static string KubeConfigEnvironmentVariable { get; set; } = "KUBECONFIG";
/// <summary>
/// Exec process timeout
/// </summary>
public static TimeSpan ExecTimeout { get; set; } = TimeSpan.FromMinutes(2);
/// <summary>
/// Exec process Standard Errors
/// </summary>
public static event EventHandler<DataReceivedEventArgs> ExecStdError;
/// <summary>
/// Initializes a new instance of the <see cref="KubernetesClientConfiguration" /> from default locations
/// If the KUBECONFIG environment variable is set, then that will be used.
@@ -552,25 +562,25 @@ namespace k8s
try
{
process.Start();
if (ExecStdError != null)
{
process.ErrorDataReceived += (s, e) => ExecStdError.Invoke(s, e);
process.BeginErrorReadLine();
}
}
catch (Exception ex)
{
throw new KubeConfigException($"external exec failed due to: {ex.Message}");
}
var stdout = process.StandardOutput.ReadToEnd();
var stderr = process.StandardError.ReadToEnd();
if (string.IsNullOrWhiteSpace(stderr) == false)
{
throw new KubeConfigException($"external exec failed due to: {stderr}");
}
// Wait for a maximum of 5 seconds, if a response takes longer probably something went wrong...
process.WaitForExit(5);
try
{
var responseObject = KubernetesJson.Deserialize<ExecCredentialResponse>(stdout);
if (!process.WaitForExit((int)(ExecTimeout.TotalMilliseconds)))
{
throw new KubeConfigException("external exec failed due to timeout");
}
var responseObject = KubernetesJson.Deserialize<ExecCredentialResponse>(process.StandardOutput.ReadToEnd());
if (responseObject == null || responseObject.ApiVersion != config.ApiVersion)
{
throw new KubeConfigException(