kubernetes-client/csharp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Add a parameter to the GenericClient class that configures the disposal of the underlying client (#1274)

Browse Source
This commit is contained in:
Ivan Josipovic
2023-04-23 17:45:12 -07:00
committed by GitHub
parent 2f290783e4
commit 5e881551e6
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/KubernetesClient/GenericClient.cs
View File

@@ -11,6 +11,7 @@ namespace k8s
private readonly string group; private readonly string group;
private readonly string version; private readonly string version;
private readonly string plural; private readonly string plural;
private readonly bool disposeClient;
[Obsolete] [Obsolete]
public GenericClient(KubernetesClientConfiguration config, string group, string version, string plural) public GenericClient(KubernetesClientConfiguration config, string group, string version, string plural)
@@ -18,17 +19,18 @@ namespace k8s
{ {
} }
public GenericClient(IKubernetes kubernetes, string version, string plural) public GenericClient(IKubernetes kubernetes, string version, string plural, bool disposeClient = true)
: this(kubernetes, "", version, plural) : this(kubernetes, "", version, plural, disposeClient)
{ {
} }
public GenericClient(IKubernetes kubernetes, string group, string version, string plural) public GenericClient(IKubernetes kubernetes, string group, string version, string plural, bool disposeClient = true)
{ {
this.group = group; this.group = group;
this.version = version; this.version = version;
this.plural = plural; this.plural = plural;
this.kubernetes = kubernetes; this.kubernetes = kubernetes;
this.disposeClient = disposeClient;
} }
public async Task<T> CreateAsync<T>(T obj, CancellationToken cancel = default) public async Task<T> CreateAsync<T>(T obj, CancellationToken cancel = default)
@@ -151,7 +153,10 @@ namespace k8s
protected virtual void Dispose(bool disposing) protected virtual void Dispose(bool disposing)
{ {
kubernetes.Dispose(); if (disposeClient)
{
kubernetes.Dispose();
}
} }
} }
} }