kubernetes-client/csharp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix a race condition. (#212)

Browse Source 
when multiple call to GetStream happens around the same time, on the
same inputIndex, a race condition will cause this.buffers.Add() to throw
exception.
This commit is contained in:
Xin Yan
2018-10-25 22:21:27 -07:00
committed by Brendan Burns
parent 99dc2f7aaf
commit 25523d1985
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/KubernetesClient/StreamDemuxer.cs
View File

@@ -98,9 +98,9 @@ namespace k8s
/// </returns> /// </returns>
public Stream GetStream(byte? inputIndex, byte? outputIndex) public Stream GetStream(byte? inputIndex, byte? outputIndex)
{ {
if (inputIndex != null && !this.buffers.ContainsKey(inputIndex.Value)) lock (this.buffers)
{ {
lock (this.buffers) if (inputIndex != null && !this.buffers.ContainsKey(inputIndex.Value))
{ {
var buffer = new ByteBuffer(); var buffer = new ByteBuffer();
this.buffers.Add(inputIndex.Value, buffer); this.buffers.Add(inputIndex.Value, buffer);